add-tax-support
main
Adds totalWithTaxCents on top of the cart module.
Plain PR comment for fixture capture (edited by probe)
Review with an inline comment for fixture capture
@@ -0,0 +6,4 @@
discount?: Discount,
): number {
const base = totalCents(items, discount)
return base + base * (taxRatePercent / 100)
This returns fractional cents - needs rounding
Probe: reply to inline comment
Adapter smoke test: full review flow
Adapter smoke: tax addition should round to whole cents
No dependencies set.
The note is not visible to the blocked user.
Adds totalWithTaxCents on top of the cart module.
Plain PR comment for fixture capture (edited by probe)
Review with an inline comment for fixture capture
@@ -0,0 +6,4 @@discount?: Discount,): number {const base = totalCents(items, discount)return base + base * (taxRatePercent / 100)This returns fractional cents - needs rounding
Probe: reply to inline comment
Adapter smoke test: full review flow
@@ -0,0 +6,4 @@discount?: Discount,): number {const base = totalCents(items, discount)return base + base * (taxRatePercent / 100)Adapter smoke: tax addition should round to whole cents
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.